Refactoring SolidStateDetectors.jl extension #67
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #67 +/- ##
==========================================
- Coverage 34.25% 33.97% -0.28%
==========================================
Files 28 28
Lines 1854 1863 +9
==========================================
- Hits 635 633 -2
- Misses 1219 1230 +11 ☔ View full report in Codecov by Sentry. |
| end | ||
|
|
||
|
|
||
| function create_SSD_config_dict_from_LEGEND_metadata(meta::PropDict, xtal_meta::X; dicttype = Dict{String,Any}) where {X <: Union{PropDict, LegendDataManagement.NoSuchPropsDBEntry}} |
There was a problem hiding this comment.
I removed the dependency on OrderedCollections and introduced the keyword dicttype which (by default) is set to Dict{String, Any}.
We can reintroduce the dependency on OrderedCollections in a follow-up PR, but it is not needed in this refactoring PR.
| sim.detector = SolidStateDetector(sim.detector, contact_id = 1, contact_potential = 0) # Set potential to 0V to avoid long simulation times | ||
| sim.detector = SolidStateDetector(sim.detector, contact_id = 2, contact_potential = 0) # (we just need the PointTypes for the active volume) | ||
| calculate_electric_potential!(sim, max_tick_distance = 0.1u"mm", refinement_limits = missing, verbose = false) | ||
| SolidStateDetectors.apply_initial_state!(sim, ElectricPotential, Grid(sim, max_tick_distance = 0.1u"mm")) |
There was a problem hiding this comment.
Changing this prevents the tests from failing on Julia 1.11
| # The creation via config files allows to save Simulations to files using LegendHDF5IO | ||
| lh5name = "$(detname).lh5" | ||
| isfile(lh5name) && rm(lh5name) | ||
| @test_nowarn ssd_write(lh5name, sim) | ||
| @test isfile(lh5name) | ||
| @test sim == ssd_read(lh5name, Simulation) | ||
| @test_nowarn rm(lh5name) | ||
| @test !isfile(lh5name) |
There was a problem hiding this comment.
These tests would previously fail:
Now that Simulation has a config_dict, the sim can actually be written and read using LegendHDF5IO.
|
Great work, thanks @bene73 and @fhagemann . Could you maybe add the details about the |
|
Done! |
In this new implementation of the SolidStateDetectors.jl extension, a config dictionary based on the detector metadata is created first and is afterwards used to create a
SolidStateDetectors.SolidStateDetectoror aSolidStateDetectors.Simulationobject.Previously it was only possible to create a
SolidStateDetectors.SolidStateDetectorobject directly, which had no config dictionary. Thus, it was not possible to correctly save simulations in the HDF5 file format, which is now possible.Except for the config dictionary, the resulting objects are the same as before.
The usage of the extension is the same as before, however now it is also possible to create a
SolidStateDetectors.Simulationobject: